feat: implement Nano (XNO) off-chain message signing (ORIS-001)#217
Open
cbrunnkvist wants to merge 9 commits into
Open
feat: implement Nano (XNO) off-chain message signing (ORIS-001)#217cbrunnkvist wants to merge 9 commits into
cbrunnkvist wants to merge 9 commits into
Conversation
|
@cbrunnkvist is attempting to deploy a commit to the MoonPay Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
done-done ™ |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Implement Nano Off-chain Message Standard to support the
sign_messageinterface for the Nano (XNO) chain.Example CLI output:
Implementation note
Raw byte signing is deliberately unsupported for Nano off-chain messages in order to prevent protocol confusion between block signatures and general signatures; the "NOMS" specification implemented by the PR is designed precisely to safely wrap off-chain text.
What this means for OWS
The standard OWS
sign_message& CLI behaves identically to other chains for the end-user while securely conforming to the domain-separated Nano standard internally!Technical notes
blake2anded25519-dalek(hazmat) from the original implementation.uint32specification before yielding aSignerError(a potential source of bugs otherwise).Testing
test_sign_message_nomscargo test --workspace268 total tests).