fix(cli): incorrect/unnecessary passphrase assumptions#224
Open
0xferrous wants to merge 1 commit into
Open
Conversation
|
@0xferrous is attempting to deploy a commit to the MoonPay Team on Vercel. A member of the Team first needs to authorize it. |
952723d to
c8b2182
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Don't make empty passphrase assumptions in wallet create/import/export/decrypt.
Why
read_passphrasecurrently:OWS_PASSPHRASE,LWS_PASSPRASE."".Given this, there is no need for us to assume:
ows wallet import,ows wallet create. This assumption creates poor security for human users."", even in cases whenOWS_PASSPHRASEwas explicitly set.Closes #
Testing
cargo test --workspacepassescargo clippy --workspace -- -D warningsis cleannpm testpasses (if Node bindings changed)owsCLINotes
Anything reviewers should know.