ci(lint): adopt the canonical org lint gate - #30
Merged
Conversation
Adds the identical caller every repo in the seven Bundu Foundation orgs now uses, calling the single reusable lint policy in nyuchi/.github, plus the canonical .prettierrc, .prettierignore, .markdownlint.jsonc, .yamllint.yaml and .editorconfig. Markdown fixes found by the gate: the README tagline used bold emphasis as a heading (MD036), which is now a blockquote; tables are normalised to markdownlint's compact pipe style; SECURITY.md's bare contact address is now a proper link; and the RFC template's list is surrounded by blank lines. KNOWN RED: `lint / JSON validity` fails on mcp/ntl-postgres-mcp-server/tsconfig.json, which contains a legal JSONC comment. TypeScript supports comments in tsconfig.json; the shared check parses every *.json with strict JSON and so rejects it. That is a defect in the check, not in this file, and the comment it objects to documents why exactOptionalPropertyTypes is deliberately off. Deleting it to make a parser happy would be the wrong repair. A fix to the shared reusable is pending; this PR is set to auto-merge once it lands. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the identical lint caller every repo in the seven Bundu Foundation orgs now uses, calling the single reusable policy in
nyuchi/.github, plus the canonical config files.Markdown fixes the gate found
SECURITY.mdbare contact address is now a proper link (MD034).Known red:
lint / JSON validitymcp/ntl-postgres-mcp-server/tsconfig.jsoncontains a legal JSONC comment. TypeScript explicitly supports comments intsconfig.json; the shared check parses every*.jsonwith strict JSON and rejects it.This is a defect in the check, not in the file. The comment it objects to documents why
exactOptionalPropertyTypesis deliberately off — that the MCP SDK's ownTransportandCallToolResulttypes are not written for it. Deleting a correct explanation to satisfy a parser pointed at the wrong file type would be the wrong repair, so I have not done it.A fix to the shared reusable (parse the JSONC-by-specification filenames —
tsconfig*.json,jsconfig*.json,.vscode/*.json,devcontainer.json,.eslintrc.json— with a JSONC parser, keeping strict JSON everywhere else) is pending a decision. Auto-merge is armed, so this PR lands itself the moment that ships.The other four contexts are green.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com