Skip to content

Fix ShellCheck CI false positives and harden ShellCheck workflow permissions #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkocman merged 4 commits into from
May 17, 2026
+6 −0
Merged

Fix ShellCheck CI false positives and harden ShellCheck workflow permissions #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9ffcbb
Initial plan
Copilot May 17, 2026
852626d
fix: avoid shellcheck false positives for os-release vars
Copilot May 17, 2026
43c1b23
Merge origin/main and resolve shellcheck conflict
Copilot May 17, 2026
1350cf2
ci: set minimal token permissions for shellcheck workflow
Copilot May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/shellcheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ name: ShellCheck
on:
pull_request:

permissions:
contents: read

jobs:
shellcheck:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions opensuse-migration-tool
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,11 @@ if [[ ! -f /etc/os-release ]]; then
exit 2
fi
# Source OS release info
# shellcheck disable=SC1091
# shellcheck source=/etc/os-release
source /etc/os-release
NAME=${NAME:-}
VERSION=${VERSION:-}
ARCH=$(uname -i) # x86_64 XXX: check for other arches

# Fetch distribution data from API
Expand Down