build: make pre-seed a default feature#1197
Merged
Merged
Conversation
pre-seed deps (aws-sdk-s3, flate2, tar) are already compiled for other default features. No reason to gate it — it's a core boot-time capability.
chaodu-agent
force-pushed
the
fix/enable-pre-seed-unified
branch
from
b72d759 to
98e417d
Compare
chaodu-agent
changed the title
pahud
approved these changes
Jun 25, 2026
thepagent
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
pre-seeda default feature instead of opt-in. Its deps (aws-sdk-s3,flate2,tar) are already compiled for other default features (config-s3,secrets-aws). No reason to gate a core boot-time capability behind a feature flag.[hooks.pre_seed]now works in all builds — standard and unified — without extra flags.