[codex] Support Basic roots in build and fix single-child diff traversal#115
Closed
weedon-openai wants to merge 2 commits intomainfrom
Closed
[codex] Support Basic roots in build and fix single-child diff traversal#115weedon-openai wants to merge 2 commits intomainfrom
weedon-openai wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR combines two related updates:
WidgetTemplate.build(...)to supportBasicroots directly.childrenis represented as a single object.User impact
Basiccan now be built through the standardbuild(...)API and used inWidgetItemwithout requiring a separate build path.childrenis a single component object, avoiding missed text delta events.Root causes
CardandListView, which preventedbuild(...)from validatingBasicroots.diff_widgettraversal only iteratedchildrenas lists; it did not recurse whenchildrenwas a singular component.Fixes
chatkit/widgets.py:BasicRoottoStrictWidgetRoot.DynamicWidgetRoot.typeto include"Basic".WidgetTemplate.build_basic(...)and direct callers tobuild(...).chatkit/server.py:diff_widgetto handle both single-child objects and child lists.tests/test_widgets.py:WidgetTemplate.build(...)returns aDynamicWidgetRootwithtype == "Basic"for basic-root templates and works inWidgetItem.build_basic(...)emitsDeprecationWarningwhile preserving behavior.childrenis a single dynamic component object.Validation
make test122 passed