[Night Shift] Add rescue edge case tests and audit README#204
[Night Shift] Add rescue edge case tests and audit README#204Pgarciapg wants to merge 3 commits intoopenai:mainfrom
Conversation
…olation Add tests/args.test.mjs covering parseArgs (boolean flags, value options, inline values, short aliases, passthrough positionals, missing value error) and splitRawArgumentString (space splitting, single/double quotes, backslash escaping, trailing backslash). Add tests/prompts.test.mjs covering interpolateTemplate (single key, multiple keys, unknown key, no placeholders, duplicate key). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cover graceful output when codex returns empty stdout, correct error message formatting on non-zero exit codes and signals, timeout/stall handling with slow-task and interruptible-slow-task behaviors, cancel interruption of running turns, parseStructuredOutput edge cases, and binaryAvailable for missing binaries. Add "empty-stdout" behavior to the fake codex fixture. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…EADME The README documented all 7 commands and the rescue subagent but omitted the three internal skills (codex-cli-runtime, codex-result-handling, gpt-5-4-prompting) that ship with the plugin. Add them to the "After install" section with a note that they are not user-invocable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1913aef7d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| const result = binaryAvailable("__nonexistent_binary_12345__"); | ||
| assert.equal(result.available, false); | ||
| assert.match(result.detail, /not found/); |
There was a problem hiding this comment.
This assertion is too platform-specific and will fail on Windows: binaryAvailable executes commands with shell: process.platform === "win32" in plugins/codex/scripts/lib/process.mjs, so a missing command typically yields cmd.exe text like "is not recognized" rather than containing "not found". In a Windows test run, this makes the new edge-case test fail even though binaryAvailable correctly reports available: false.
Useful? React with 👍 / 👎.
1 participant
Summary
parseStructuredOutputedge cases, andbinaryAvailablefor missing binaries.empty-stdoutbehavior to the fake codex fixture for testing graceful fallback.codex-cli-runtime,codex-result-handling,gpt-5-4-prompting) to the "After install" section.Test plan
tests/rescue-edge-cases.test.mjspassruntime.test.mjsconfirmed on base branch)🤖 Generated with Claude Code