fix(cli): render nested scan configuration values as JSON - #246
Conversation
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Pull request overview
This PR improves the CLI scan-history “CONFIGURATION” rendering so that nested saved scan configuration values (objects/arrays) are displayed as compact JSON rather than default string coercions like [object Object] or comma-joined arrays, while keeping the existing scalar formatting and sanitization behavior.
Changes:
- Render config values that are objects/arrays via
JSON.stringifybefore sanitizing and printing. - Add regression coverage ensuring nested feature flags and configured path arrays render as compact JSON strings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/typescript/src/scan-history-renderer.ts | Updates configuration entry rendering to stringify object/array values as compact JSON. |
| sdk/typescript/tests-ts/scan-history-renderer.test.ts | Adds assertions covering nested object and array config rendering in scan history output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
[object Object]or flattened comma-separated values.Verification
bun test --timeout 30000 ./tests-ts— 773 passed, 5 skippedbun test --timeout 30000 ./tests-ts/scan-history-renderer.test.ts— 6 passedtsc --noEmitprettier --check src/scan-history-renderer.ts tests-ts/scan-history-renderer.test.ts