Skip to content

fix(cli): render nested scan configuration values as JSON - #246

Merged
mldangelo-oai merged 2 commits into
mainfrom
mdangelo/codex/fix-scan-config-rendering
Aug 4, 2026
Merged

fix(cli): render nested scan configuration values as JSON#246
mldangelo-oai merged 2 commits into
mainfrom
mdangelo/codex/fix-scan-config-rendering

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

  • Render nested saved scan configuration objects and arrays as compact JSON instead of [object Object] or flattened comma-separated values.
  • Preserve existing scalar formatting and terminal-control sanitization.
  • Add regression coverage for nested feature flags and configured path arrays.

Verification

  • bun test --timeout 30000 ./tests-ts — 773 passed, 5 skipped
  • bun test --timeout 30000 ./tests-ts/scan-history-renderer.test.ts — 6 passed
  • tsc --noEmit
  • prettier --check src/scan-history-renderer.ts tests-ts/scan-history-renderer.test.ts

@github-actions github-actions Bot added the bug Something isn't working label Aug 4, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review Please review exact head b4141dd, focusing on nested object and array serialization, unchanged scalar formatting, and terminal-control sanitization in saved scan configuration.

@mldangelo-oai
mldangelo-oai requested a review from Copilot August 4, 2026 00:09
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: b4141dd3df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the CLI scan-history “CONFIGURATION” rendering so that nested saved scan configuration values (objects/arrays) are displayed as compact JSON rather than default string coercions like [object Object] or comma-joined arrays, while keeping the existing scalar formatting and sanitization behavior.

Changes:

  • Render config values that are objects/arrays via JSON.stringify before sanitizing and printing.
  • Add regression coverage ensuring nested feature flags and configured path arrays render as compact JSON strings.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdk/typescript/src/scan-history-renderer.ts Updates configuration entry rendering to stringify object/array values as compact JSON.
sdk/typescript/tests-ts/scan-history-renderer.test.ts Adds assertions covering nested object and array config rendering in scan history output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review Please review exact head 2d3d487, focusing on compact object and array serialization, preserved scalar/null rendering, and terminal-control sanitization.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 2d3d4871f3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 2d3d4871f3

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@mldangelo-oai
mldangelo-oai merged commit 93f3794 into main Aug 4, 2026
16 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/fix-scan-config-rendering branch August 4, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants