fix: make verbose scan reruns and cost failures actionable by mldangelo-oai · Pull Request #253 · openai/codex-security

mldangelo-oai · 2026-08-04T00:23:58Z

Summary

Support --verbose for saved scan reruns without changing authentication selection.
Include configured scan budgets in verbose configuration diagnostics.
Classify exceeded budgets correctly and report both observed and maximum cost.
Reuse existing rerun, authentication, and budget tests instead of duplicating fixtures.
Preserve existing credential and provider-identifier logging behavior.

Validation

Full Bun test suite: 773 passed, 5 expected platform/integration skips, 0 failed across 34 files.
Focused CLI, authentication, and workbench suites: 142 passed.
All 19 built-CLI smoke scenarios passed, including JSON/JSONL reruns, environment precedence, profiles, and budget failures.
Fresh npm installation validated the CLI, public import, 95 bundled plugin files, and all 179 package entries.
node --run build, node --run lint, node --run format, and node --run generate:models:check all passed.

mldangelo-oai · 2026-08-04T00:24:03Z

@codex review exact head 9d7434a

Please review saved-scan verbose flag handling, preservation of existing authentication selection, and cost-limit diagnostics.

mldangelo-oai · 2026-08-04T00:25:30Z

@codex review exact head 9d7434a

Please review the ready-for-review PR, focusing on saved-scan verbose behavior, unchanged authentication selection, and budget-limit diagnostics.

Copilot

Pull request overview

This PR improves the CLI’s verbose diagnostics for scan reruns and cost-limit failures so that rerun behavior and budget overruns are more actionable while preserving existing authentication-selection behavior.

Changes:

Adds --verbose support to scans rerun, including schema exposure and forwarding into the scan runner.
Includes max_cost_usd in verbose scan.configuration diagnostics.
Correctly classifies ScanCostLimitExceededError as cost_limit_exceeded and logs both max_cost_usd and estimated_usd in verbose failure diagnostics.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
sdk/typescript/tests-ts/cli.test.ts	Adds regression coverage for rerun schema/options, verbose reruns/auth selection, cost-limit configuration logging, and cost-limit failure diagnostics.
sdk/typescript/src/cli.ts	Implements `scans rerun --verbose`, adds max-cost to configuration diagnostics, and enriches/classifies cost-limit failures.
sdk/typescript/README.md	Documents `scans rerun SCAN_ID --verbose` and clarifies what verbose reruns provide.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

chatgpt-codex-connector · 2026-08-04T00:27:33Z

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 9d7434ab64

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-04T00:28:53Z

Security review completed. No security issues were found in this pull request.

Reviewed commit: 9d7434ab64

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

mldangelo-oai · 2026-08-04T00:32:01Z

@codex review exact head 92f2b9d

Please review the simplified rerun implementation, consolidated JSON/JSONL authentication coverage, and cost-limit diagnostics.

chatgpt-codex-connector · 2026-08-04T00:34:07Z

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 92f2b9d836

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (2)

sdk/typescript/src/cli.ts:886

scans rerun --verbose uses the same redaction/sanitization as other verbose scan diagnostics, but the option description currently implies raw diagnostics. Align the wording with the scan command to avoid suggesting unredacted output.

        verbose: z
          .boolean()
          .default(false)
          .describe("Print scan diagnostics to stderr."),
      }),

sdk/typescript/src/cli.ts:2977

partial_output in the scan.failed diagnostic is derived only from the local scanDir variable. If a ScanInterruptedError (including ScanCostLimitExceededError) is thrown with a scanDir before onOutputDirReady runs, the message will correctly mention partial output, but the diagnostic will incorrectly report partial_output=false.

            : classifyConnectionFailure(failure),
      partial_output: scanDir !== null,
      max_cost_usd: costLimitFailure?.maxCostUsd,
      estimated_usd: costLimitFailure?.cost.estimatedUsd,

chatgpt-codex-connector · 2026-08-04T00:35:32Z

Security review completed. No security issues were found in this pull request.

Reviewed commit: 92f2b9d836

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

mldangelo-oai · 2026-08-04T00:35:42Z

@codex review exact head fa26b7d

Please review the code-only verbose rerun and budget-diagnostic changes; the README is unchanged.

chatgpt-codex-connector · 2026-08-04T00:37:57Z

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: fa26b7d572

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

chatgpt-codex-connector · 2026-08-04T00:39:18Z

Security review completed. No security issues were found in this pull request.

Reviewed commit: fa26b7d572

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

mldangelo-oai added 2 commits August 3, 2026 16:58

fix: make verbose scan reruns and cost failures actionable

7bb1dbd

fix: preserve rerun authentication and avoid partial settings

9d7434a

github-actions Bot added the bug Something isn't working label Aug 4, 2026

mldangelo-oai marked this pull request as ready for review August 4, 2026 00:25

mldangelo-oai requested a review from Copilot August 4, 2026 00:25

Copilot started reviewing on behalf of mldangelo-oai August 4, 2026 00:25 View session

Copilot AI reviewed Aug 4, 2026

View reviewed changes

refactor: simplify verbose scan coverage and rerun handling

92f2b9d

mldangelo-oai requested a review from Copilot August 4, 2026 00:31

Copilot started reviewing on behalf of mldangelo-oai August 4, 2026 00:32 View session

Copilot AI reviewed Aug 4, 2026

View reviewed changes

docs: keep existing verbose scan documentation unchanged

fa26b7d

mldangelo-oai requested a review from Copilot August 4, 2026 00:35

Copilot started reviewing on behalf of mldangelo-oai August 4, 2026 00:36 View session

Copilot AI reviewed Aug 4, 2026

View reviewed changes

ianw-oai approved these changes Aug 4, 2026

View reviewed changes

mldangelo-oai merged commit 50e2ad0 into main Aug 4, 2026
16 checks passed

mldangelo-oai deleted the mdangelo/codex/fix-verbose-scan-diagnostics branch August 4, 2026 00:41

Uh oh!

Conversation

mldangelo-oai commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Uh oh!

mldangelo-oai commented Aug 4, 2026

Uh oh!

mldangelo-oai commented Aug 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

chatgpt-codex-connector Bot commented Aug 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 4, 2026

Uh oh!

mldangelo-oai commented Aug 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

chatgpt-codex-connector Bot commented Aug 4, 2026

Uh oh!

mldangelo-oai commented Aug 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

chatgpt-codex-connector Bot commented Aug 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mldangelo-oai commented Aug 4, 2026 •

edited

Loading