feat(scan): show current findings for each repository - #346
Merged
Conversation
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for pushing this toward more consistent repeat scans; carrying forward open findings seems directly useful for the customer feedback.
One scope edge case I noticed: get_scan_feedback currently selects earlier findings by repository/target, but not by the newly requested path scope or diff. In an isolated workbench check, a scan scoped to allowed/ received a previous_findings.json entry for outside/private.py.
Would it make sense to filter the carried-forward findings to the current authorized paths before writing the context artifact? That would preserve the consistency benefit without bringing unrelated finding details into a scoped scan.
mldangelo-oai
previously approved these changes
Aug 11, 2026
kmbroai
previously approved these changes
Aug 11, 2026
kmbroai
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification