Skip to content

feat(scan): show current findings for each repository - #346

Merged
kmbroai merged 9 commits into
mainfrom
dev/ianw/codex-security-honest-comparison
Aug 11, 2026
Merged

feat(scan): show current findings for each repository#346
kmbroai merged 9 commits into
mainfrom
dev/ianw/codex-security-honest-comparison

Conversation

@ianw-oai

@ianw-oai ianw-oai commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Show one list of open findings for each repository after every scan.
  • Match current findings to earlier findings and remove duplicates.
  • Keep false positives hidden, including findings with a new identity.
  • Keep earlier findings visible when the current scan does not confirm them.
  • Match earlier findings even when a scan cost limit is set.

Verification

  • 1,008 tests passed; 11 platform-specific tests were skipped.
  • Type checks, formatting, and package build passed.
  • Added cases for false positives, explicit reopen, repository isolation, provider credentials, pagination, cost limits, and matching failures.
  • Fixed the macOS login test fixture and verified it in CI.

@github-actions github-actions Bot added the bug Something isn't working label Aug 11, 2026
@ianw-oai ianw-oai changed the title fix: report missing findings as unknown on unchanged source fix(scan): check findings from earlier scans Aug 11, 2026

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this toward more consistent repeat scans; carrying forward open findings seems directly useful for the customer feedback.

One scope edge case I noticed: get_scan_feedback currently selects earlier findings by repository/target, but not by the newly requested path scope or diff. In an isolated workbench check, a scan scoped to allowed/ received a previous_findings.json entry for outside/private.py.

Would it make sense to filter the carried-forward findings to the current authorized paths before writing the context artifact? That would preserve the consistency benefit without bringing unrelated finding details into a scoped scan.

@ianw-oai ianw-oai changed the title fix(scan): check findings from earlier scans feat(scan): show current findings for each repository Aug 11, 2026
@github-actions github-actions Bot added enhancement New feature or request and removed bug Something isn't working labels Aug 11, 2026
@ianw-oai
ianw-oai requested a review from kmbroai August 11, 2026 20:59
mldangelo-oai
mldangelo-oai previously approved these changes Aug 11, 2026
kmbroai
kmbroai previously approved these changes Aug 11, 2026
@kmbroai
kmbroai dismissed stale reviews from mldangelo-oai and themself via 1f26710 August 11, 2026 21:40
@kmbroai
kmbroai merged commit 8487e09 into main Aug 11, 2026
17 checks passed
@kmbroai
kmbroai deleted the dev/ianw/codex-security-honest-comparison branch August 11, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants