feat(cli): inspect saved scan and worker logs - #349
Merged
Conversation
kmbroai
approved these changes
Aug 11, 2026
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for adding scan/worker log visibility and preserving session IDs for failed scans; both are directly helpful for auditability.
A few edge cases I noticed while exercising this:
set_scan_threadcurrently overwritescontinuation_thread_ideven when another owner is already set or the scan has completed. The earlier commit already had running-state/existing-owner checks; restoring those would preserve the existing ownership and cancellation behavior.scans logsalways searches the dedicated SDK home, while native plugin scans can have their sessions under the ambient Codex home. In a fixture, the session existed but the command could not find it from the managed home.- Session-parent discovery does not recognize
forked_from_id, although the existing workbench usage helper does; a forked worker was omitted in my check.
It might be possible to reuse the existing session-lineage discovery to cover both the home/lineage cases and avoid parsing every unrelated historical session. Happy to separate anything that is intentionally CLI-only from the broader plugin behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scans logs SCAN_IDto return saved scan and worker events directly.Tests