feat(sdk): attribute Responses traffic to SDK and CLI - #350
Conversation
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
kmbroai
left a comment
There was a problem hiding this comment.
responses_api_metadata cool
Summary
sdkand CLI scans, validation/patch commands, and semantic scan comparisons toclithroughresponses_api_metadata.codex_security_surface.createSecuritywhile keeping CLI-versus-SDK runtime selection internal.Why
Responses traffic from Codex Security needs an explicit surface marker so product analytics can distinguish requests originating from the public SDK and CLI.
Verification
bun test --randomize --seed 12345 --timeout 30000 ./tests-ts— 1,008 passed; 11 platform-specific tests skipped.bun test --timeout 30000 tests-ts/api-environment.test.ts tests-ts/api-surface.test.ts tests-ts/cli-skills.test.ts tests-ts/scan-comparison.test.ts— 30 passed.pnpm run typespnpm run formatpnpm run buildpnpm packandpnpm run check:package -- <tarball>— verified the 203-entry release artifact, installed public import and CLI, 107 bundled plugin files, bundled Codex, and a nested worker.