Skip to content

feat(sdk): attribute Responses traffic to SDK and CLI - #350

Merged
mldangelo-oai merged 2 commits into
mainfrom
mdangelo/codex/attribute-responses-surface
Aug 11, 2026
Merged

feat(sdk): attribute Responses traffic to SDK and CLI#350
mldangelo-oai merged 2 commits into
mainfrom
mdangelo/codex/attribute-responses-surface

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Attribute SDK scans to sdk and CLI scans, validation/patch commands, and semantic scan comparisons to cli through responses_api_metadata.codex_security_surface.
  • Export createSecurity while keeping CLI-versus-SDK runtime selection internal.
  • Add focused regression coverage for both scan surfaces and CLI skill-command configuration, with environment-value coverage in its dedicated test module.

Why

Responses traffic from Codex Security needs an explicit surface marker so product analytics can distinguish requests originating from the public SDK and CLI.

Verification

  • bun test --randomize --seed 12345 --timeout 30000 ./tests-ts — 1,008 passed; 11 platform-specific tests skipped.
  • bun test --timeout 30000 tests-ts/api-environment.test.ts tests-ts/api-surface.test.ts tests-ts/cli-skills.test.ts tests-ts/scan-comparison.test.ts — 30 passed.
  • pnpm run types
  • pnpm run format
  • pnpm run build
  • pnpm pack and pnpm run check:package -- <tarball> — verified the 203-entry release artifact, installed public import and CLI, 107 bundled plugin files, bundled Codex, and a nested worker.

Copy link
Copy Markdown
Collaborator Author

@codex review the exact current head e47c180. Focus on CLI-versus-SDK Responses metadata across scans, semantic comparisons, validation/patch commands, and the public createSecurity factory.

@github-actions github-actions Bot added the enhancement New feature or request label Aug 11, 2026
@mldangelo-oai
mldangelo-oai marked this pull request as ready for review August 11, 2026 20:49

Copy link
Copy Markdown
Collaborator Author

@codex review the exact current head 3a152c3. Verify CLI-versus-SDK Responses attribution and that the focused attribution and environment tests match the approved change.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 3a152c3f02

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 3a152c3f02

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@kmbroai kmbroai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

responses_api_metadata cool

@mldangelo-oai
mldangelo-oai merged commit 30e4a11 into main Aug 11, 2026
19 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/attribute-responses-surface branch August 11, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants