fix: notarize macOS binary by submitting archive - #458
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a619efc3a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| notarize: | ||
| macos: | ||
| - enabled: '{{ isEnvSet "MACOS_SIGN_P12" }}' | ||
| artifacts: archive |
There was a problem hiding this comment.
In the tag-release path I checked (.github/workflows/release.yml runs goreleaser release --clean with version: "~> v2"), this added key makes the GoReleaser config invalid before any release artifacts are produced. GoReleaser’s notarize.macos config supports ids, enabled, sign, and notarize, while its YAML loader enables strict known-field decoding, so artifacts under this section is rejected as an unknown field rather than selecting archives. See the upstream config/docs: https://goreleaser.com/customization/sign/notarize/ and https://raw.githubusercontent.com/goreleaser/goreleaser/main/pkg/config/config.go.
Useful? React with 👍 / 👎.
|
Notarization didn't finish before the binaries started uploading to GitHub. |
|
@codex review |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
any news here? |
|
There's no news, the binary is still being killed, we're waiting for the maintainers to look at the issue and pR |
2 participants
This pull request makes a small configuration change to the
.goreleaser.ymlfile to improve the notarization process for macOS builds.timeoutto 20 minutes and enabledwaitto ensure the process completes before continuing.