Apply backpressure to live exec output subscribers - #464
Merged
yzhuang-oai merged 3 commits intoAug 25, 2026
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2818b340a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fkorotkov-oai
previously approved these changes
Aug 25, 2026
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
yzhuang-oai
force-pushed
the
codex/orchard-exec-backpressure
branch
from
August 25, 2026 21:59
abb1a42 to
7ac2673
Compare
yzhuang-oai
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live exec subscribers currently use a non-blocking send. When their 128-frame queue fills, Orchard disconnects the subscriber and loses subsequent output and the exit frame.
Reuse
sendLocked, the blocking send path already used for history replay. This preserves frame order, applies backpressure, and still stops when the subscriber closes.Add a regression test that sends 256 stdout frames and verifies the final exit frame.
Reproduction
The regression fails on current
mainwithsubscriber closed before output frame 128.Verification
go test ./internal/controller -run '^TestExecSessionLiveOutputAppliesBackpressure$' -count=1go test ./internal/controller -count=1go test -race ./internal/controller -run '^TestExecSessionLiveOutputAppliesBackpressure$' -count=1go vet ./internal/controllergit diff --check