Wait for Tart and Vetu stop completion - #472
Open
yzhuang-oai wants to merge 1 commit into
Open
Conversation
yzhuang-oai
marked this pull request as ready for review
September 1, 2026 16:14
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Share one Stop completion per run and retain Stopping until both the stop command and VM cleanup finish. Expose transition conditions to reconciliation and return after requesting Stop so it cannot apply a generation or restart the VM early. Cover both completion orders, repeated and concurrent calls, restart, and generation acknowledgement with bounded fake-command regressions. Allow process startup under parallel test load while preserving explicit shutdown ordering.
yzhuang-oai
force-pushed
the
dev/yzhuang/orchard-stop-completion
branch
from
September 1, 2026 16:27
2714086 to
603990e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated or concurrent
Stopcalls can report completion while the VM process or its cleanup is still running. Reconciliation can then acknowledge a new specification or restart the VM before shutdown finishes.Share one completion channel per run in both Tart and Vetu, keep the
Stoppingcondition visible until the stop command and VM cleanup finish, and defer specification changes while that transition is in progress.Regression tests cover both command completion orders, concurrent callers, repeated stops, restarts, and generation acknowledgement. Runtime tests use controlled Tart and Vetu command fixtures.
Validation:
go test -race -count=1 -timeout=120s ./internal/worker/vmmanager/... ./internal/worker.