Preserve suspended Tart clone configuration - #473
Open
yzhuang-oai wants to merge 1 commit into
Open
Conversation
yzhuang-oai
marked this pull request as ready for review
September 1, 2026 16:15
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Read the cloned VM state before applying resource overrides or randomizing its MAC address and serial. Suspended clones must retain the configuration used to save their state. Cover suspended and stopped clones through the command runner, including assigned resource precedence, optional image FQN lookup, and metadata command and JSON errors.
yzhuang-oai
force-pushed
the
dev/yzhuang/orchard-suspended-clones
branch
from
September 1, 2026 16:27
c7b1cff to
2f3093b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A suspended Tart clone must retain the hardware configuration used when its state was saved. Applying the normal resource overrides and MAC address or serial randomization can make the saved state unusable.
Read the cloned VM's state before configuration and skip
tart setfor suspended clones. Stopped clones keep the existing configuration behavior, including assigned CPU and memory precedence. Metadata lookup and decoding failures remain errors.Suspended images must already have the desired hardware configuration; resource overrides apply to stopped clones.
Validation: command-runner regressions cover suspended and stopped clones, optional image FQN lookup, and metadata errors. Ran
go test -count=1 -timeout=120s ./internal/worker/vmmanager/tart ./internal/worker/vmmanager/vetu ./internal/worker/vmmanager/base.