Bound worker log retention - #476
Open
yzhuang-oai wants to merge 1 commit into
Open
Conversation
yzhuang-oai
marked this pull request as ready for review
September 1, 2026 16:17
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Keep at most five rotated worker log files for up to fourteen days and compress them. Retain the existing 100 MB rotation threshold so long-running workers do not accumulate an unlimited number of log backups.
yzhuang-oai
force-pushed
the
dev/yzhuang/orchard-log-retention
branch
from
September 1, 2026 16:27
3118d4e to
321bfd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worker log rotation limits the size of each file but leaves rotated backups unbounded. Keep at most five backups for up to fourteen days and compress them, while retaining the existing 100 MB rotation threshold.
Validation:
go test -count=1 -timeout=120s ./internal/command/workerand the combined Orchard build.