Add endpoint support - #478
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
Endpoint listeners bind :port, so every exposed VM service listens on all worker network interfaces. There is no bind-address/exposure scope in EndpointSpec, so an internal VM service can be unintentionally published to the worker's surrounding network. Default to loopback or require an explicit exposure scope, and test the listener address.
The merge-base changed after approval.
419b9b5 to
bba8ffe
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bba8ffebeb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // SemanticallyEqual treats omitted and explicitly empty collections as equal. | ||
| func SemanticallyEqual[T any](current, desired T) bool { | ||
| return cmp.Equal(current, desired, cmpopts.EquateEmpty()) | ||
| } |
There was a problem hiding this comment.
Because pkg/resource/v1 is a public importable package, replacing the exported VMSpec.SemanticallyEqual method with this package-level generic function breaks source compatibility: downstream callers using current.SemanticallyEqual(desired) will fail to compile after upgrading even though the behavior still exists. Keep the original method as a wrapper while using the generic helper internally.
Useful? React with 👍 / 👎.
Thanks for the heads-up, this is intended. Making docs more explicit in a0177db. |
3 participants
This allows exposing services running in a VM directly on the Orchard Worker's machine, thus one can avoid the need to use port-forwarding and have less intermediaries.