Conversation
|
@thomasarsouze : if you modify the namespace, you will have to change all the tests, the examples, and the doc also. |
|
@pradal : yes this is what I thought, but as mentioned yesterday, we're working first on packages that already have the namespace, which is not the case here. |
|
@thomasarsouze I think that this is a good idea to harmonize the way openalea packages are treated, although it makes things a bit verbose. |
|
Sorry for the late reply @RamiALBASHA. Indeed it is much safer to have a new release associated with this namespace change to prevent code break or at least make it easier to debug. As the hydroshoot package manager, I let you decide how to tag your version. |
thomasarsouze
left a comment
There was a problem hiding this comment.
Tests all pass ok. However, before merging, please be aware that at the moment, Caribu with corrected namespace has not been released on all OS / python versions (cf. here).
Issue is currently handled though: openalea/caribu#50
|
Ok, thanks @thomasarsouze. Is there any deadline for merging? I need to take my time on this issue. |
|
No rush... |
|
@RamiALBASHA I will create another issue that list all the steps to release hydroshoot. Then you will be able to install hydroshoot (old version) or openalea.hydroshoot (new namespace) from conda |
No description provided.