Skip to content

feat(spindle-ui): navigation tabにCapsule StyleとInline Styleを追加 - #2187

Open
yanagi0602 wants to merge 3 commits into
mainfrom
feat/update-navigation-tab
Open

feat(spindle-ui): navigation tabにCapsule StyleとInline Styleを追加#2187
yanagi0602 wants to merge 3 commits into
mainfrom
feat/update-navigation-tab

Conversation

@yanagi0602

Copy link
Copy Markdown
Contributor

NavigationTabのCapsule StyleとInline Styleを追加しました。
それに際して、UnderlineTabに存在したロジックを一部hooksとして切り出し、それぞれで使う対応も加えています。

既存のバグ修正

テストケースとして、キーボード操作を担保するものを追加しており、それに伴って発見された初回レンダー時のfocus移動の問題を修正しました。

再現確認手順

  1. https://ameba-spindle.web.app/?path=/story/navigationtab-underlinetab--variant-fixed へアクセスしtabでfocusを当てる
  2. 隣の項目へ→キーを押下して移動
  3. 選択値が変わるがfocusが移動していないことを確認
  4. 新しいStoryで再度ためし解消されていることを確認

@yanagi0602 yanagi0602 self-assigned this Jul 15, 2026
@changeset-bot

changeset-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 52f4541

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit 52f4541):

https://ameba-spindle--pr2187-feat-update-navigati-5stm76ci.web.app

(expires Fri, 14 Aug 2026 05:48:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e7521619a2dd5c653490c8246e81ec2a5c8f1435

@reg-suit

reg-suit Bot commented Jul 15, 2026

Copy link
Copy Markdown

reg-suit detected visual differences.

Check this report, and review them.

🔴 Changed ⚪ New 🔵 Passing
7 7 252
How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants