Final GHA polish#1640
Open
gregorydlogan wants to merge 4 commits into
Open
Conversation
…ed PRs for security reasons. Thus, we do the lame thing and write the PR number to an artifact which we then download.
…tifact does not exist
gregorydlogan
added
type:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hopefully finally fixes all of the remaining GHA issues. Several of these will only take effect once they're merged into
develop, but some affect the branch itself so I'm putting them all here and merging them forward for sanity purposes.First, we fixed the communication between the build of the branch and container image, and the deploy of them. GHA blanks the list of PRs in the
workflow_runrun event when filing PRs between forks for 'security reasons'.Second, we only fire the subsequent deploys if the parent is successful.
I don't see any further issues in my fork. That being said, one of the issues being fixed here is that the behaviour between forks sooo...