feat: editor comment support#7452
Conversation
…hing the functionality available in the Admin UI. - Add comment and reply processing in editor POST endpoint edit.json (create, update, delete for both comments and replies)
|
Form submitted - G |
|
For those curious, I have confirmed that this is a student at Munster. @Bennit99 did you fill out the ICLA form? Apereo can take quite some time to process them. |
|
Yes, I filled out the ICLA online form. |
|
I now also tested this with the frontend part. Works as expected. |
add displayName (from User.getName) to comments and ommentReply, use orElseThrow instead of orElse(0L) for getting comments, revert prettier fromatting changes
| } | ||
| } | ||
| } | ||
| } catch (EventCommentException e) { |
There was a problem hiding this comment.
@Bennit99 I'm not sure if you're still around, but my only complaint here is that errors are silently swallowed. I would like to see an exception thrown here so that setEditData can pass the relevant exception upwards.
That being said, it's been quite a long time so this does not block the merge from my end.
There was a problem hiding this comment.
I took over for @Bennit99 and can adapt this. The front-end side needs more work anyway, so this doesn't need to get merged yet. I hope this is all done for Opencast 21.
4 participants
Add full comment and reply support to the Opencast video editor, matching the functionality available in the Admin UI.
How to test this patch
Your pull request should…