docs: document SwiftLint and SwiftFormat prerequisites - #299
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 30, 2026, 9:18 PM ET / July 31, 2026, 01:18 UTC. ClawSweeper reviewWhat this changesThe PR adds SwiftLint and SwiftFormat, with a Homebrew install command, to the source-build prerequisites in Merge readinessThis active docs-only PR is the linked implementation candidate for the still-open report about missing source-build validation prerequisites. The proposed clarification is narrow, consistent with repository guidance that validation uses SwiftLint and SwiftFormat, and should remain open for ordinary maintainer approval and merge handling. Priority: P3 Review scores
Verification
How this fits together
flowchart LR
A[Source contributor] --> B[Build guide]
B --> C[Prerequisite setup]
C --> D[pnpm validation helpers]
D --> E[SwiftLint and SwiftFormat]
E --> F[Build and validation results]
Before merge
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Technical reviewBest possible solution: Merge this focused prerequisite clarification after ordinary maintainer review so the linked issue can close automatically with the documentation fix. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR documents prerequisite tooling rather than repairing an executable runtime failure. The linked report supplies the relevant developer setup context. Is this the best way to solve the issue? Yes. Adding the missing tools beside the existing source-build prerequisites is the narrowest maintainable solution and avoids changing validation scripts or configuration. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 8448599ab899. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (7 earlier review cycles)
|
Closes #294
What Problem This Solves
Fixes an issue where users building Peekaboo from source could miss that the repository validation helpers require SwiftLint and SwiftFormat.
Why This Change Was Made
The build guide already lists the source-build prerequisites, so this adds the missing formatter and linter tools there with the Homebrew install command. This is intentionally documentation-only and does not change build scripts, lint configuration, or release behavior.
User Impact
Developers following the source-build guide can install the expected validation tools before running the pnpm helper scripts, avoiding avoidable setup failures.
Evidence
node scripts/docs-lint.mjsdocs-lint: okgit diff --checkDisclosure: AI was used to understand the codebase and review the fix.