Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a466209f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discardPersistentStateflag through the public runtime contract and ACPX runtime manager0.5.2and document the reset fix inCHANGELOG.mdWhy
OpenClaw bound ACP resets could look successful but silently reopen the same persistent backend session on the next turn. In practice that meant Claude/Codex channels could keep old context after reset even when the local binding had been rotated.
Validation
pnpm run typecheckpnpm run build:test && node --test dist-test/test/runtime-manager.test.js dist-test/test/runtime.test.js dist-test/test/client.test.jspnpm run buildpnpm run check:docsnode dist/cli.js --approve-all --timeout 120 claude exec "Reply with exactly ACPX_052_CLAUDE_OK and nothing else."node dist/cli.js --approve-all --timeout 120 codex exec "Reply with exactly ACPX_052_CODEX_OK and nothing else."Embedded manual proof
With OpenClaw linked to this local ACPX branch, I manually verified the live
claude-1bound session flow:{\"ok\":true}acp_session_id1, proving only the new message was in context