sec (3/9): require an active {{target}} in user-defined scanners#27
Open
jesse-merhi wants to merge 1 commit into
Open
sec (3/9): require an active {{target}} in user-defined scanners#27jesse-merhi wants to merge 1 commit into
jesse-merhi wants to merge 1 commit into
Conversation
A BYOS command that never expands {{target}} outside quotes and comments can
return valid JSON and be recorded as a completed scan that never received the
target. Replace scannerTargetPlaceholdersAreUnquoted with
scannerTargetPlaceholderState, which reports both whether every placeholder is
unquoted and how many are active, and reject commands with zero active
placeholders.
This was referenced Jul 23, 2026
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: sec (3/9): require an active {{target}} in user-defined scanners This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
A user-defined scanner
commandmust contain at least one active{{target}}placeholder — one that is not inside shell quotes and not after a#comment. A command with no active placeholder is rejected atconfig-resolution time.
Why it matters
The whole point of a scanner command is that ClawScan substitutes the target
path into it. If
{{target}}is missing (or only appears quoted/commented), thescanner runs against nothing — the run looks like it scanned the skill but the
tool never saw it, producing a false "clean". Failing loudly at config time
prevents a silently no-op scanner.
Before / after (runnable)
notarget.yml:A placeholder that is only inside quotes, or only after a
#, is likewiserejected; a normal
scan {{target}}is accepted.Verify