sec (6/9): run user-defined scanners in an isolated working directory#30
Open
jesse-merhi wants to merge 1 commit into
Open
sec (6/9): run user-defined scanners in an isolated working directory#30jesse-merhi wants to merge 1 commit into
jesse-merhi wants to merge 1 commit into
Conversation
The scanner used to run with a working directory derived from the target: the target's parent directory, or the target itself when it was a directory. That handed the scanner writable access to files sitting next to the target, and under Docker that parent became a writable bind mount. Run host scanners in a fresh os.MkdirTemp directory (removed after the run) and keep the Docker cwd empty so nothing target-derived is mounted; the container workdir is already isolated. Removes the now-unused userDefinedScannerCWD helper.
This was referenced Jul 23, 2026
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: sec (6/9): run user-defined scanners in an isolated working directory This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
A user-defined scanner no longer runs with its working directory set to the
target's folder. On a host run it now runs in a fresh isolated temp directory
(
clawscan-scanner-*, removed after the run); under Docker the workdir staysempty so nothing target-adjacent is mounted.
Why it matters
Running with cwd = the target's directory hands the scanner writable access
to every file sitting next to the target. A malicious or buggy scanner could
modify or drop files beside the skill being scanned (and under Docker that
directory would be a writable bind mount). Giving the scanner a private throwaway
cwd removes that ambient write access; the target is still passed explicitly as
an argument.
Before / after (runnable)
Scanner that records its cwd and tries to write a neighbor file:
NEIGHBOR_LEAKlands next to the skillVerify
TestUserDefinedScannerUsesIsolatedCwdasserts the host run's cwd is a freshtemp dir (not the target dir) and that Docker runs use an empty workdir.