Filter ClawSweeper command status activity#267
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 7, 2026, 1:07 PM ET / 17:07 UTC. Summary Reproducibility: yes. from source inspection: current main computes command-like activity before the bot issue-comment routine filter, so a bot-authored edited comment containing Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the narrow marker-backed bot issue-comment filter with its regression coverage once required checks pass and maintainers accept the automation-surface risk. Do we have a high-confidence way to reproduce the issue? Yes from source inspection: current main computes command-like activity before the bot issue-comment routine filter, so a bot-authored edited comment containing Is this the best way to solve the issue? Yes. Filtering ClawSweeper marker-backed bot issue_comment activity before command-like matching is a narrow repair that preserves explicit human commands and adds focused regression coverage. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 413ef258a1ef. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
@clawsweeper re-review PR body now includes supported Node 24 notifier proof showing the redacted #90328-style bot command-status |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Fixes #266.
Summary
Real Behavior Proof
Observed on openclaw/openclaw#90328 after the final manual
@clawsweeper re-review: multipleClawSweeper Dispatchruns were triggered byissue_commentevents without new pushes or new manual commands, while ClawSweeper labels/rating/status churned. The status comment body contained marker-backed command/status text such as:After this patch,
routineGithubActivityReasontreats bot-authored activity containing ClawSweeper command ack/status/progress markers as routine activity before command-like matching, while preserving explicit human command handling.Supported-runtime after-fix notifier proof using Node 24 and the redacted #90328 marker-backed bot
issue_comment.editedevent shape:Focused Node 24 regression output, showing explicit commands still route while command-status bot edits are skipped:
Validation
pnpm exec oxfmt --check src/repair/notify-github-activity.ts test/repair/notify-github-activity.test.tspnpm run build:repairnpx -y node@24 dist/repair/notify-github-activity.js --input /tmp/clawsweeper-pr267-proof/status-comment-edited-event.json --event issue_comment --write-report --report /tmp/clawsweeper-pr267-proof/github-activity-report.jsonnpx -y node@24 --test --test-name-pattern='routineGithubActivityReason (keeps explicit ClawSweeper commands visible|filters ClawSweeper command status comment edits)' test/repair/notify-github-activity.test.tspnpm run lint:repair -- src/repair/notify-github-activity.ts