Derive public PR status labels from report state#285
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 13, 2026, 2:08 PM ET / 18:08 UTC. Summary Reproducibility: yes. Source inspection shows current main's public-rendering paths read PR status from stale frontmatter labels, while the linked issue reports the latest durable verdict should move the PR to ready-for-maintainer review. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Merge the narrow derived-status fix after normal maintainer review and required checks, preserving the existing live apply path that passes context-derived status into the renderer. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows current main's public-rendering paths read PR status from stale frontmatter labels, while the linked issue reports the latest durable verdict should move the PR to ready-for-maintainer review. Is this the best way to solve the issue? Yes. Reusing the existing report-state classifier before falling back to stored labels is a narrow fix that avoids adding a parallel status policy. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against f398bbc24221. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Added a focused real render check for the stale waiting-label case. $ pnpm run build && node --test --test-name-pattern "public PR review details derive ready status instead of preserving stale waiting label" test/clawsweeper.test.ts
✔ public PR review details derive ready status instead of preserving stale waiting label (6.43125ms)
ℹ tests 1
ℹ pass 1The same PR-head renderer output for the stale @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Fixes #280.
Summary
Validation