feat(docs): support markdown in docs update#642
Conversation
|
Codex review: needs changes before merge. Reviewed May 28, 2026, 5:50 PM ET / 21:50 UTC. Summary Reproducibility: yes. Source inspection shows the markdown range helper sends delete, insert, and formatting requests, while Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land the feature after markdown range replacement derives its request count from the actual batch requests and covers that output with a focused assertion. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows the markdown range helper sends delete, insert, and formatting requests, while Is this the best way to solve the issue? No. The feature direction is maintainable, but the implementation should return or compute the actual markdown replace batch request count instead of hard-coding it. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 929e26b4a999. Label changesLabel changes:
Label justifications:
Evidence reviewedAcceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
ClawSweeper PR egg ✨ Hatched: 🥚 common Frosted Crabkin Hatch commandComment Hatchability rules:
Rarity: 🥚 common. What is this egg doing here?
|
|
Really nice direction — Proposed surface: Semantics: delete content in Why it pairs with
Use cases (the ones I keep hitting):
Happy to test on a live doc once it lands. Thanks again for picking this up. |
|
Added this in 001a1f9. The updated PR now supports both plain and markdown range replacement on gog docs update <id> --replace-range START:END --text replacement
gog docs update <id> --markdown --replace-range START:END --file body.mdSemantics are the proposed low-level primitive: callers provide the UTF-16 Docs API range; gog deletes that range and inserts the replacement at START. It composes with Validation run:
|
|
Also updated the repo-local agent skill docs in
|
Summary
Testing