[codex] Preserve full chat text for Tray TTS#900
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 1, 2026, 2:41 AM ET / 06:41 UTC. Summary Reproducibility: yes. from source inspection: current main truncates assistant notification text at 200 characters and Tray TTS reads that same preview field. I did not run a live Windows tray reproduction in this read-only review. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the narrow preview/full-text split only after required validation and current-head tray read-aloud proof, while keeping toast, history, activity, and categorization surfaces on the existing preview text. Do we have a high-confidence way to reproduce the issue? Yes from source inspection: current main truncates assistant notification text at 200 characters and Tray TTS reads that same preview field. I did not run a live Windows tray reproduction in this read-only review. Is this the best way to solve the issue? Yes, the proposed split is the narrow maintainable direction as long as full text stays limited to the TTS path and preview text remains the toast/history/categorization source. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 4166e0fd63f8. Label changesLabel changes:
Label justifications:
Evidence reviewedAcceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
OpenClawNotification.FullMessageMessageFullMessagewhile falling back toMessageWhy
Tray read-aloud currently uses the same notification preview text that is truncated for toast/history display, so long assistant responses stop around the preview boundary.
Validation
dotnet test tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj -c Release --filter FullyQualifiedName~OpenClawGatewayClientTestsdotnet test tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj -c Release