Skip to content

fix: resolve WCAG accessibility violations across all app pages #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karkarl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve WCAG accessibility violations across all app pages #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/OpenClaw.Tray.WinUI/Pages/ConnectionPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1739,6 +1739,8 @@ private Border BuildSavedGatewayRowControl(SavedGatewayRow row)
VerticalAlignment = VerticalAlignment.Center,
Tag = row.Id,
};
Microsoft.UI.Xaml.Automation.AutomationProperties.SetName(overflowBtn,
string.Format(LocalizationHelper.GetString("ConnectionPage_GatewayOptionsA11y"), row.DisplayName));
overflowBtn.Content = new FontIcon
{
Glyph = Helpers.FluentIconCatalog.MoreOverflow,
Expand Down Expand Up @@ -1789,6 +1791,7 @@ private Border BuildSavedGatewayRowControl(SavedGatewayRow row)
grid.Children.Add(overflowBtn);

card.Child = grid;
Microsoft.UI.Xaml.Automation.AutomationProperties.SetName(card, row.DisplayName);
return card;
}

Expand Down
3 changes: 2 additions & 1 deletion src/OpenClaw.Tray.WinUI/Pages/PermissionsPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,8 @@
<TextBox Grid.Column="0" x:Uid="NewRulePattern" x:Name="NewRulePattern"
PlaceholderText="Command pattern (e.g. echo *)"
FontFamily="Consolas"/>
<ComboBox Grid.Column="1" x:Name="NewRuleAction" MinWidth="100" SelectedIndex="0">
<ComboBox Grid.Column="1" x:Name="NewRuleAction" MinWidth="100" SelectedIndex="0"
AutomationProperties.Name="Rule action">
<ComboBoxItem x:Uid="PermissionsPage_ComboBoxItem_54" Content="Deny" Tag="deny"/>
<ComboBoxItem x:Uid="PermissionsPage_ComboBoxItem_55" Content="Allow" Tag="allow"/>
<ComboBoxItem x:Uid="PermissionsPage_ComboBoxItem_56" Content="Ask" Tag="prompt"/>
Expand Down
15 changes: 11 additions & 4 deletions src/OpenClaw.Tray.WinUI/Pages/SandboxPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@
<StackPanel Spacing="8" Margin="0,4,0,12">
<TextBlock x:Name="UnavailableActionMessage" TextWrapping="Wrap" />
<StackPanel Orientation="Horizontal" Spacing="8">
<Button x:Name="UnavailablePrimaryButton" Click="OnUnavailableActionClick" Style="{ThemeResource AccentButtonStyle}" />
<Button x:Name="UnavailablePrimaryButton" Click="OnUnavailableActionClick" Style="{ThemeResource AccentButtonStyle}"
AutomationProperties.Name="Sandbox action" />
<HyperlinkButton x:Uid="SandboxPage_LearnMoreAboutMXC" Content="Learn more about MXC sandboxing"
NavigateUri="https://github.com/microsoft/mxc" />
</StackPanel>
Expand Down Expand Up @@ -163,7 +164,8 @@
Padding="20,18"
MinHeight="130"
CornerRadius="8"
Click="OnPresetLockedClick">
Click="OnPresetLockedClick"
AutomationProperties.Name="Locked Down preset: No internet, no clipboard, no standard user folders">
<StackPanel Spacing="8">
<TextBlock x:Uid="SandboxPage_LockedDown" Text="🔒 Locked Down"
FontSize="18"
Expand All @@ -184,7 +186,8 @@
Padding="20,18"
MinHeight="130"
CornerRadius="8"
Click="OnPresetBalancedClick">
Click="OnPresetBalancedClick"
AutomationProperties.Name="Recommended preset: Internet on, read-only on Documents, Downloads, Desktop">
<StackPanel Spacing="8">
<TextBlock x:Uid="SandboxPage_Recommended" Text="🛡 Recommended"
FontSize="18"
Expand All @@ -205,7 +208,8 @@
Padding="20,18"
MinHeight="130"
CornerRadius="8"
Click="OnPresetPermissiveClick">
Click="OnPresetPermissiveClick"
AutomationProperties.Name="Unprotected preset: Internet on, read and write on Documents, Downloads, Desktop">
<StackPanel Spacing="8">
<TextBlock x:Uid="SandboxPage_Unprotected" Text="⚠ Unprotected"
FontSize="18"
Expand Down Expand Up @@ -255,6 +259,7 @@
<TextBlock x:Uid="SandboxPage_Documents" Grid.Row="0" Grid.Column="0" Text="Documents" VerticalAlignment="Center"/>
<ComboBox x:Name="DocsAccessCombo" Grid.Row="0" Grid.Column="1"
HorizontalAlignment="Stretch"
AutomationProperties.Name="Documents access level"
SelectionChanged="OnDocsAccessChanged">
<ComboBoxItem x:Uid="SandboxPage_Blocked" Content="Blocked" Tag="None" />
<ComboBoxItem x:Uid="SandboxPage_ReadOnly" Content="Read only" Tag="ReadOnly" />
Expand All @@ -264,6 +269,7 @@
<TextBlock x:Uid="SandboxPage_Downloads" Grid.Row="1" Grid.Column="0" Text="Downloads" VerticalAlignment="Center"/>
<ComboBox x:Name="DownloadsAccessCombo" Grid.Row="1" Grid.Column="1"
HorizontalAlignment="Stretch"
AutomationProperties.Name="Downloads access level"
SelectionChanged="OnDownloadsAccessChanged">
<ComboBoxItem x:Uid="SandboxPage_Blocked2" Content="Blocked" Tag="None" />
<ComboBoxItem x:Uid="SandboxPage_ReadOnly2" Content="Read only" Tag="ReadOnly" />
Expand All @@ -273,6 +279,7 @@
<TextBlock x:Uid="SandboxPage_Desktop" Grid.Row="2" Grid.Column="0" Text="Desktop" VerticalAlignment="Center"/>
<ComboBox x:Name="DesktopAccessCombo" Grid.Row="2" Grid.Column="1"
HorizontalAlignment="Stretch"
AutomationProperties.Name="Desktop access level"
SelectionChanged="OnDesktopAccessChanged">
<ComboBoxItem x:Uid="SandboxPage_Blocked3" Content="Blocked" Tag="None" />
<ComboBoxItem x:Uid="SandboxPage_ReadOnly3" Content="Read only" Tag="ReadOnly" />
Expand Down
3 changes: 2 additions & 1 deletion src/OpenClaw.Tray.WinUI/Pages/SettingsPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@
TextWrapping="Wrap"/>
</StackPanel>
<ComboBox Grid.Column="1" x:Name="NotificationSoundComboBox" MinWidth="140"
AutomationProperties.AutomationId="SettingsPageSound">
AutomationProperties.AutomationId="SettingsPageSound"
AutomationProperties.Name="Notification sound">
<ComboBoxItem x:Uid="SettingsPage_ComboBoxItem_48" Content="Default" Tag="Default"/>
<ComboBoxItem x:Uid="SettingsPage_ComboBoxItem_49" Content="None" Tag="None"/>
<ComboBoxItem x:Uid="SettingsPage_ComboBoxItem_50" Content="Subtle" Tag="Subtle"/>
Expand Down
10 changes: 7 additions & 3 deletions src/OpenClaw.Tray.WinUI/Pages/VoiceSettingsPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,20 @@
<StackPanel Grid.Column="1" Orientation="Horizontal" Spacing="8" VerticalAlignment="Top">
<Button x:Uid="VoiceSettingsPage_AssistantRefreshButton"
x:Name="AssistantRefreshButton" Click="OnAssistantRefreshClick" Padding="10,8"
ToolTipService.ToolTip="Refresh assistant status">
ToolTipService.ToolTip="Refresh assistant status"
AutomationProperties.Name="Refresh voice assistant status">
<FontIcon Glyph="&#xE72C;" FontSize="14"/>
</Button>
<Button x:Name="AssistantStartButton" Click="OnAssistantStartClick"
Style="{StaticResource AccentButtonStyle}">
Style="{StaticResource AccentButtonStyle}"
AutomationProperties.Name="Start voice assistant">
<StackPanel Orientation="Horizontal" Spacing="6">
<FontIcon Glyph="&#xE768;" FontSize="14"/>
<TextBlock x:Uid="VoiceSettingsPage_AssistantStartButtonText" Text="Start"/>
</StackPanel>
</Button>
<Button x:Name="AssistantStopButton" Click="OnAssistantStopClick">
<Button x:Name="AssistantStopButton" Click="OnAssistantStopClick"
AutomationProperties.Name="Stop voice assistant">
<StackPanel Orientation="Horizontal" Spacing="6">
<FontIcon Glyph="&#xE71A;" FontSize="14"/>
<TextBlock x:Uid="VoiceSettingsPage_AssistantStopButtonText" Text="Stop"/>
Expand Down Expand Up @@ -193,6 +196,7 @@
<StackPanel Spacing="8">
<TextBlock x:Uid="VoiceSettingsPage_LanguageHeader" x:Name="LanguageHeaderText" Text="Language" Style="{StaticResource BodyStrongTextBlockStyle}"/>
<ComboBox x:Name="LanguageCombo"
AutomationProperties.Name="Voice language"
SelectionChanged="OnLanguageChanged" Width="200">
<ComboBoxItem x:Uid="VoiceSettingsPage_LangAuto" Content="Auto-detect" Tag="auto"/>
<ComboBoxItem x:Uid="VoiceSettingsPage_LangEn" Content="English" Tag="en"/>
Expand Down
3 changes: 3 additions & 0 deletions src/OpenClaw.Tray.WinUI/Strings/en-us/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5455,6 +5455,9 @@ Make sure the gateway is running.</value>
<data name="ConnectionPage_OpenDashboard" xml:space="preserve">
<value>Open dashboard</value>
</data>
<data name="ConnectionPage_GatewayOptionsA11y" xml:space="preserve">
<value>Options for {0}</value>
</data>
<data name="ConnectionPage_DisconnectAction" xml:space="preserve">
<value>Disconnect</value>
</data>
Expand Down
3 changes: 3 additions & 0 deletions src/OpenClaw.Tray.WinUI/Strings/fr-fr/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5450,6 +5450,9 @@ Assurez-vous que la passerelle est en cours d'exécution.</value>
<data name="ConnectionPage_OpenDashboard" xml:space="preserve">
<value>Ouvrir le tableau de bord</value>
</data>
<data name="ConnectionPage_GatewayOptionsA11y" xml:space="preserve">
<value>Options pour {0}</value>
</data>
<data name="ConnectionPage_DisconnectAction" xml:space="preserve">
<value>Déconnecter</value>
</data>
Expand Down
3 changes: 3 additions & 0 deletions src/OpenClaw.Tray.WinUI/Strings/nl-nl/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5451,6 +5451,9 @@ Controleer of de gateway actief is.</value>
<data name="ConnectionPage_OpenDashboard" xml:space="preserve">
<value>Dashboard openen</value>
</data>
<data name="ConnectionPage_GatewayOptionsA11y" xml:space="preserve">
<value>Opties voor {0}</value>
</data>
<data name="ConnectionPage_DisconnectAction" xml:space="preserve">
<value>Verbinding verbreken</value>
</data>
Expand Down
3 changes: 3 additions & 0 deletions src/OpenClaw.Tray.WinUI/Strings/zh-cn/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5450,6 +5450,9 @@
<data name="ConnectionPage_OpenDashboard" xml:space="preserve">
<value>打开仪表板</value>
</data>
<data name="ConnectionPage_GatewayOptionsA11y" xml:space="preserve">
<value>{0} 的选项</value>
</data>
<data name="ConnectionPage_DisconnectAction" xml:space="preserve">
<value>断开连接</value>
</data>
Expand Down
3 changes: 3 additions & 0 deletions src/OpenClaw.Tray.WinUI/Strings/zh-tw/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5450,6 +5450,9 @@
<data name="ConnectionPage_OpenDashboard" xml:space="preserve">
<value>開啟儀表板</value>
</data>
<data name="ConnectionPage_GatewayOptionsA11y" xml:space="preserve">
<value>{0} 的選項</value>
</data>
<data name="ConnectionPage_DisconnectAction" xml:space="preserve">
<value>中斷連線</value>
</data>
Expand Down
Loading
Loading