server: avoid logging an error when deploying plugins#71
Open
brianneville wants to merge 1 commit intoopenconfig:masterfrom
Open
server: avoid logging an error when deploying plugins#71brianneville wants to merge 1 commit intoopenconfig:masterfrom
brianneville wants to merge 1 commit intoopenconfig:masterfrom
Conversation
when a plugin is deployed, we were moving and then deleting the temporary file. However we are unconditionally calling chunkWriter.Cleanup when exiting from handleImageTransfer, which means that for plugins we would be always logging an error. In this change, we change the Cleanup function so that it can be called multiple times, but will only run once, and will always return the error from the first invocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a plugin is deployed, we were moving and then deleting the temporary file.
However we are unconditionally calling chunkWriter.Cleanup when exiting from handleImageTransfer, which means that for plugins we would be always logging an error.
In this change, we change the Cleanup function so that it can be called multiple times, but will only run once, and will always return the error from the first invocation.