Revise gNMI-3.7 test cases for clarity and accuracy - #5498
Conversation
Updated test cases for gNMI-3.7 to clarify invalid configurations and their handling in CLI and OC. Removed outdated examples and added new scenarios for MTU configuration errors.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the documentation and test scenarios for gNMI-3.7, focusing on improving the clarity of invalid configuration handling. By replacing ambiguous reference validation errors with concrete MTU configuration examples, the changes ensure that test cases are more representative of real-world validation failures. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5498 / 868a60aVirtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request updates the union_replace_test documentation by simplifying the error scenarios to use MTU configuration for non-existent interfaces instead of BGP or QoS policies. Feedback was provided to fix an incomplete sentence, correct spelling errors, and resolve an inconsistency between a section header and its description.
|
I decided to include these changes in #5451 |
Updated test cases for gNMI-3.7 to clarify invalid configurations and their handling in CLI and OC. Removed outdated examples and added new scenarios for MTU configuration errors.