Skip to content

Revise gNMI-3.7 test cases for clarity and accuracy - #5498

Closed
dplore wants to merge 2 commits into
mainfrom
dplore-patch-16
Closed

Revise gNMI-3.7 test cases for clarity and accuracy#5498
dplore wants to merge 2 commits into
mainfrom
dplore-patch-16

Conversation

@dplore

@dplore dplore commented May 21, 2026

Copy link
Copy Markdown
Member

Updated test cases for gNMI-3.7 to clarify invalid configurations and their handling in CLI and OC. Removed outdated examples and added new scenarios for MTU configuration errors.

Updated test cases for gNMI-3.7 to clarify invalid configurations and their handling in CLI and OC. Removed outdated examples and added new scenarios for MTU configuration errors.
@dplore
dplore requested a review from a team as a code owner May 21, 2026 17:37
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the documentation and test scenarios for gNMI-3.7, focusing on improving the clarity of invalid configuration handling. By replacing ambiguous reference validation errors with concrete MTU configuration examples, the changes ensure that test cases are more representative of real-world validation failures.

Highlights

  • Documentation Update: Updated the gNMI-3.7 test case documentation to remove outdated references and clarify error scenarios.
  • Test Scenario Refinement: Replaced generic BGP policy and QoS queue reference errors with specific MTU configuration errors for non-existent interfaces to improve test accuracy.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot

OpenConfigBot commented May 21, 2026

Copy link
Copy Markdown

Pull Request Functional Test Report for #5498 / 868a60a

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
gNMI-3: union_replace
d09ab7d6 Log
Cisco 8000E status
gNMI-3: union_replace
ccf99867 Log
Cisco XRd status
gNMI-3: union_replace
b37b9b73 Log
Juniper ncPTX status
gNMI-3: union_replace
0bed1332 Log
Nokia SR Linux status
gNMI-3: union_replace
edcb1bc2 Log
Openconfig Lemming status
gNMI-3: union_replace
c6450092 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
gNMI-3: union_replace
Cisco 8808 status
gNMI-3: union_replace
Juniper PTX10008 status
gNMI-3: union_replace
Nokia 7250 IXR-10e status
gNMI-3: union_replace

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the union_replace_test documentation by simplifying the error scenarios to use MTU configuration for non-existent interfaces instead of BGP or QoS policies. Feedback was provided to fix an incomplete sentence, correct spelling errors, and resolve an inconsistency between a section header and its description.

Comment thread feature/gnmi/tests/union_replace_test/README.md
Comment thread feature/gnmi/tests/union_replace_test/README.md
Comment thread feature/gnmi/tests/union_replace_test/README.md
@dplore

dplore commented May 21, 2026

Copy link
Copy Markdown
Member Author

I decided to include these changes in #5451

@dplore dplore closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants