Add support for caller to determine origin for union_replace - #184
Merged
Conversation
Coverage Report for CI Build 26060810708Coverage increased (+0.03%) to 4.469%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
robshakir
requested changes
May 11, 2026
robshakir
left a comment
robshakir
left a comment
Member
There was a problem hiding this comment.
I'm not sure I actually see the implementation of the description here (or at least it's not tested).
Can you please add unit tests that demonstrate the setting of the value of the origin to the value set by the caller?
Member
Author
I'll raise a separate PR for this one, standby |
…e type-sniffing assumption between string and *string.
robshakir
reviewed
May 18, 2026
Member
Author
|
@robshakir ready for re-review |
robshakir
approved these changes
May 18, 2026
robshakir
left a comment
robshakir
left a comment
Member
There was a problem hiding this comment.
LGTM - one minor thing I spotted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #176 we've also run into several scenarios where it is more convenient for the caller to specify the origin when using union_replace batch functions. This changes origin to match whatever is passed in by the caller.