docs: a trip is a sequence of parts, each with its own place and dates - #278
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(trips)!: each part of a trip has its own place and dates(#274) removed a trip's ownstart_date/end_dateand its flatlocations[], but left prose behind that still describes the old shape. The README's Trips bullet promised "location and dates";Course's API doc and the course dialog's end-date comment both drew a contrast against "a trip's start date", which no longer exists and whose part-level replacement is optional on both ends exactly as a course's dates are;formatDateOnlyandformatTripDateRangeinlib/date-time.tsnamed a trip as the owner of dates a part now owns; and the re-ordering notes inuseInfiniteResource.tsand its test said trips sort by start date, whereget_trips_pageorders them by the earliest start across their parts — an aggregate overtrip_part, not a column oftrip. The paragraph's point survives: that date is still one the edit dialog can change, so the row still moves.Swept the whole repository, not just
src/, reading everytriphit with each file squeezed to one line so a formatter's wrap could not hide a claim.DECISIONS.mdwas already rewritten by #274 and its cross-references still resolve;CONTRIBUTING.md,scripts/measure-navigations.mjs,privacyandtermscarry only "round trip" or claims that stayed true. Nothing about dive sites is touched.Verified with
npm run format:check,npm run lint,npm run type-checkandnpm test(220 files, 7144 tests, all passing).🤖 Generated with Claude Code