feat(dives): twin sets sit below every single-cylinder group - #282
Merged
Merged
Conversation
A twin set belongs to neither unit family - it is asked for by its total whichever way a diver reads - and it is the rarer pick, so the group carries no `system` and trails both families instead of riding in front of the imperial presets for a metric reader. Verified by the two render tests asserting the full preset order in each unit system, plus the arrow-key walk over the first heading. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The site comment carries why twin sets trail both families; the entry states the order the dropdown renders in and nothing more. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
aleskiontherun
deleted the
claude/twinsets-volume-autocomplete-1ae4de
branch
September 23, 2026 06:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cylinder volume dropdown groups its presets and leads with the ones in the reader's own unit system, which put Twin sets second for a metric diver and last for an imperial one. A twin set belongs to neither family — it is asked for by its total whichever way a diver reads — and it is the rarer pick, so the group now carries no
systemand trails both families in both systems. The reader's own singles stay nearest the box.Verified by the two render tests asserting the full preset order in each unit system and the arrow-key walk over the first heading, plus the whole suite (7154 tests), lint, type-check, format and a production build.
🤖 Generated with Claude Code