feat(settings): the import preview edits the check-in facts, and the form takes the format's bounds and anchors - #283
Merged
Conversation
…form takes the format's bounds and anchors Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an import preview carries
check_in_details, the import card shows each fact the document carries (date of birth, phone, emergency contact, insurance). The account's current value sits beside the API's proposal, and the proposal is pre-filled in the form module's own fields, so the same bounds, anchor rule and future-date guard apply. Anything left in the boxes goes back ascheck_in_detailson apply. Keep mine leaves a fact out of the submission, and emptying a fact clears it. The card re-reads the signed-in user only when the result carriescheck_in_detail_written, so the check-in card on the same page never saves stale values back. The form module takes the columns' new bounds and requires a contact's name and an insurance's provider, using the API's own messages.check_in_detail_droppedrenders as a warning. The export card's UDDF row now says what that file carries of the diver's details.Verified with
npm run lint,npm run type-checkandnpm test(unit tests for the form module and submission helpers, render tests for the import card's section, submission, anchor and refresh behaviour).🤖 Generated with Claude Code