feat(dives): a dive whose time of day is unknown shows and edits as a date - #287
Merged
Merged
Conversation
… date Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API now serves a bare
YYYY-MM-DDstart_timefor an imported dive whose time of day was never recorded, and keeps that state for as long asPATCH /dive/{uuid}receives the bare date back.isDateOnlyStartTimenames the shape;formatDiveDateTimedrops the clock for it andformatDiveStartTimestops after the date, so the list, the page header, the neighbour and merge labels, the renumber preview and the gas-use chart show a date instead of a midnight nobody recorded.splitStartTimereturns the date without a time, so the edit form echoes it unchanged, andDiveStartTimeFieldshows the date, an empty time box and a disabled offset select; typing a time sends an offsetless date-time, which ends the state. A file that states only a day, applied to such a dive, keeps it a date. The create form is unchanged.Verified with
npm run lint,type-check,test(the date tests also underTZUTC, America/Los_Angeles and Pacific/Kiritimati) andbuild.🤖 Generated with Claude Code