fix(dives): the charts fit a phone, and the NDL label clears the depth axis - #288
Open
aleskiontherun wants to merge 3 commits into
Open
aleskiontherun wants to merge 3 commits into
aleskiontherun wants to merge 3 commits into
Conversation
…r each other Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Below 560 px a chart now narrows its viewBox instead of scrolling inside a
min-w-[560px]box, so the dive profile, gas consumption and activity charts fit a phone with their axis type held at the 8.6 px it has at 560 px (fittedChartWidth,useChartWidth). X labels thin to whatever the narrower plot holds, anduseKeepInsidekeeps each hover card within its chart now that no scroll container clips it. The profile's deco-panel gap grows from 12 to 16 units, so the labels either side of each rule — depth's20against NDL's100 min, and every panel row boundary below it — no longer touch. From 560 px up the charts draw as before apart from that gap, and the dashboard chart skeleton now matches the charts' phone height.Verified in Chromium at 1024, 375 and 320 px on seeded dives and dashboards: no
<text>boxes overlap, no ancestor hasscrollWidth > clientWidth, and hover cards stay inside. New browser-lane tests check the same things and fail againstmain, andnpm run ciis green.🤖 Generated with Claude Code