Skip to content

Conversation

@mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Dec 23, 2025

  • Fix Better visualization options for groups? #245
  • Remove the cutoff kwarg which we never used
  • Color bars by the first group in the compound key
  • Instead of joining with a space, join with a semi-colon: If the key itself happened to include a semicolon, some colors might be reused. This isn't a great practice, but the downsides are small.

The first key is not necessarily the most meaningful key, but I don't want to get bogged down in graph configuration.

Not necessarily a bug, but definitely a quirk: the order of keys is different when they are inferred, versus when they are supplied explicitly. For example with sample.csv,

  • if groups are not provided, it is grade bin, and then class year.
  • if class year groups are provided, it is class year, and then grade bin.
Screenshot 2026-01-12 at 9 50 16 AM

@github-project-automation github-project-automation bot moved this to Pending in DP Wizard Dec 23, 2025
@mccalluc mccalluc moved this from Pending to Ready for Review in DP Wizard Dec 23, 2025
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@github-project-automation github-project-automation bot moved this from Ready for Review to Ready to Merge in DP Wizard Jan 13, 2026
@mccalluc mccalluc merged commit abf7c02 into main Jan 13, 2026
4 checks passed
@mccalluc mccalluc deleted the 245-color-bars branch January 13, 2026 16:48
@github-project-automation github-project-automation bot moved this from Ready to Merge to Complete in DP Wizard Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Better visualization options for groups?

3 participants