Skip to content

Random tests, and better input validation #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mccalluc merged 11 commits into from
Jan 14, 2026
Merged

Random tests, and better input validation #795

mccalluc merged 11 commits into from
Jan 14, 2026

Conversation

@mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Jan 12, 2026 •
edited
Loading

For the reviewer:

  • I started a new test file for this: While the structure is similar to other tests, I wanted to make sure I didn't confuse the two... but if this doesn't seem right, I could combine.
  • Is the text of new error messages readable?

So that there's not a moving target, I'm going to make a branch from this for the next step. If there a non-blocking suggestions here, I'd prefer to handle them in the next PR, just to keep the merge process simple.

@github-project-automation github-project-automation bot moved this to Pending in DP Wizard Jan 12, 2026
@mccalluc mccalluc marked this pull request as ready for review January 12, 2026 18:22
@mccalluc mccalluc moved this from Pending to Ready for Review in DP Wizard Jan 12, 2026
@mccalluc mccalluc mentioned this pull request Jan 12, 2026
Merged
@mccalluc
More input validation and hypothesis testing (#797)
d6471b9 
* global epsilon constraints

* typo

* user messages

* better validation of contributions

* suppress_health_check

* fix doctest
ekraffmiller
ekraffmiller approved these changes Jan 14, 2026
View reviewed changes
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@github-project-automation github-project-automation bot moved this from Ready for Review to Ready to Merge in DP Wizard Jan 14, 2026
@mccalluc mccalluc merged commit 5257abc into main Jan 14, 2026
4 checks passed
@mccalluc mccalluc deleted the 793-hypothesis branch January 14, 2026 19:24
@github-project-automation github-project-automation bot moved this from Ready to Merge to Complete in DP Wizard Jan 14, 2026
rtreacy
rtreacy reviewed Jan 15, 2026
View reviewed changes
Copy link
Collaborator

@rtreacy rtreacy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. messages are clear. constraints make sense. hard-coded constraint replaced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rtreacy rtreacy rtreacy left review comments

@ekraffmiller ekraffmiller ekraffmiller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

DP Wizard
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Try the hypothesis test library

4 participants

@mccalluc @ekraffmiller @rtreacy