Skip to content

feat: support commonAppConfig site config option#179

Open
arbrandes wants to merge 1 commit intoopenedx:mainfrom
arbrandes:common-app-config
Open

feat: support commonAppConfig site config option#179
arbrandes wants to merge 1 commit intoopenedx:mainfrom
arbrandes:common-app-config

Conversation

@arbrandes
Copy link
Contributor

@arbrandes arbrandes commented Feb 27, 2026

Description

Adds a new commonAppConfig optional site configuration field. When set, its values are merged into every app's config via getAppConfig() at the lowest priority, so app-specific config always takes precedence.

Work log
  1. Read types.ts to understand the new commonAppConfig: AppConfig field at line 62 in OptionalSiteConfig
  2. Read runtime/config/index.ts to understand how getAppConfig(), addAppConfigs(), and the appConfigs record work
  3. Initially proposed merging commonAppConfig into appConfigs at write time (in addAppConfigs()), but user preferred keeping app-specific configs separate and merging at read time
  4. Modified getAppConfig() to merge commonAppConfig from site config as the lowest-priority base using lodash.merge, with app-specific config on top
  5. Added 4 test cases to runtime/config/index.test.ts covering all merge scenarios
  6. All 18 tests pass (14 existing + 4 new)

🤖 Generated with Claude Code

Merge commonAppConfig into the output of getAppConfig() at the lowest
priority, so app-specific config values always take precedence.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant