Fix guest token errors - #163
Merged
Merged
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
bmtcril
force-pushed
the
bmtcril/fix_guest_token_errors
branch
from
July 23, 2025 20:10
e212037 to
e41fb23
Compare
saraburns1
reviewed
Jul 23, 2025
This top level settings lets us decide which dashboards to include when asking for Superset guest tokens, which fixes issues in OeX releases before Sumac and where newer versions of platform-plugin-aspects are used with older versions of tutor-contrib-aspects.
bmtcril
force-pushed
the
bmtcril/fix_guest_token_errors
branch
from
July 23, 2025 20:30
e41fb23 to
8b6fd83
Compare
saraburns1
approved these changes
Jul 24, 2025
saraburns1
reviewed
Jul 30, 2025
Previously the error messages sent upstream were eaten, making debugging very difficult. This ensures the correct messages are logged.
bmtcril
force-pushed
the
bmtcril/fix_guest_token_errors
branch
from
July 30, 2025 14:08
4101873 to
4f9d7cf
Compare
Co-authored-by: Sara Burns <sburns@axim.org>
bmtcril
added a commit
to openedx/tutor-contrib-aspects
that referenced
this pull request
Jul 30, 2025
settings Allows platform-plugin-aspects to know whether to include in-context dashboards in the request for a Superset guest token. See: openedx/platform-plugin-aspects#163
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds better error handling and use tutor-contrib-aspects'
ASPECTS_ENABLE_STUDIO_IN_CONTEXT_METRICSsetting to give more control over in-context metrics when using older versions of tutor-contrib-aspects or pre-Sumac named releases. When this flag is false we do not try to get guest tokens for the in-context dashboards when displaying the embedded Superset dashboards in the LMS Instructor dashboard.To manually test:
Set up a Tutor Redwood environment
Upgrade your tutor install to Sumac, Teak, or nightly
do convert-mysql-utf8mb4-charset--from redwoodTest
Turn on in-context metrics
ASPECTS_ENABLE_STUDIO_IN_CONTEXT_METRICSTrueTest
Closes: #162
Merge checklist:
Check off if complete or not applicable: