Skip to content

fix: use current SDK version in telemetry meter#335

Merged
SoulPancake merged 2 commits intomainfrom
fix/issue-334-meter-version
Feb 17, 2026
Merged

fix: use current SDK version in telemetry meter#335
SoulPancake merged 2 commits intomainfrom
fix/issue-334-meter-version

Conversation

@aaguiarz
Copy link
Member

@aaguiarz aaguiarz commented Feb 16, 2026

Summary

Replaces the hardcoded meter version with the SDK version constant.

Changes

  • Added regression test asserting metrics.getMeter receives SdkConstants.SdkVersion
  • Updated MetricRecorder.meter() to use SdkConstants.SdkVersion

Potential Breaking Change

  • Telemetry meter version tag changes from 0.6.3 to the actual SDK version.
  • Existing dashboards/alerts/queries filtering by the previous version value may need to be updated.

Fixes #334

@aaguiarz aaguiarz requested a review from a team as a code owner February 16, 2026 18:56
Copilot AI review requested due to automatic review settings February 16, 2026 18:56
@coderabbitai
Copy link

coderabbitai bot commented Feb 16, 2026

Warning

Rate limit exceeded

@aaguiarz has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 23 minutes and 55 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/issue-334-meter-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot
Copy link

dosubot bot commented Feb 16, 2026

Related Documentation

Checked 8 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (a7090e2) to head (3e626cb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage   89.67%   89.68%           
=======================================
  Files          25       25           
  Lines        1492     1493    +1     
  Branches      279      279           
=======================================
+ Hits         1338     1339    +1     
  Misses         94       94           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the OpenTelemetry meter was being registered with a hardcoded, stale version ("0.6.3") instead of the current SDK version. The fix replaces the hardcoded version with the centralized SdkConstants.SdkVersion constant, which currently holds version "0.9.2". This ensures telemetry metadata accurately reflects the SDK version being used, enabling proper version-based filtering and analysis.

Changes:

  • Updated MetricRecorder.meter() to use SdkConstants.SdkVersion instead of hardcoded "0.6.3"
  • Added regression test to verify meter is registered with the correct SDK version

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/telemetry/metrics.test.ts Added imports for SdkConstants and metrics module, and new test case to verify meter registration uses current SDK version
telemetry/metrics.ts Imported SdkConstants and replaced hardcoded version string with SdkConstants.SdkVersion in getMeter call

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SoulPancake SoulPancake added this pull request to the merge queue Feb 17, 2026
Merged via the queue into main with commit 9e55466 Feb 17, 2026
32 checks passed
@SoulPancake SoulPancake deleted the fix/issue-334-meter-version branch February 17, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: use current SDK version in telemetry meter registration

4 participants