Messages: added helper functions #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors the message targeting system by splitting the single targets property into two separate properties: targetAppIds for application identifiers and targetUsers for user role targets. The MessageTarget enum is renamed to MessageTargetUsers to better reflect its purpose, with a backward-compatible alias maintained in the exports.
Key Changes:
- Split
targetsproperty intotargetAppIds(string[]) andtargetUsers(MessageTargetUsers[]) - Renamed
MessageTargetenum toMessageTargetUsersfor clarity - Added corresponding getter and setter helper functions for the new properties
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/message/message.ts | Renamed MessageTarget to MessageTargetUsers, replaced single targets property key with targetAppIds and targetUsers in MessagePropsKey enum and MessageProps type |
| src/message/messages.ts | Updated import, replaced getTargets/assocTargets functions with separate getTargetAppIds/getTargetUsers/assocTargetAppIds/assocTargetUsers helper functions |
| src/message/index.ts | Added backward-compatible alias exporting MessageTargetUsers as MessageTarget |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.