Messages: added helper functions #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds helper functions to the Messages module and refactors message property naming for better clarity. The changes include new target user types for data roles, date-based message filtering, and template variable replacement functionality.
- Added getter and setter functions for date-based message scheduling and expiration
- Introduced new message target user types (DataAnalysts, DataCleaners) and enhanced user targeting logic
- Added utility functions for clearing hidden properties and replacing body template variables with user-specific data
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/message/message.ts | Added DataAnalysts and DataCleaners target user types; renamed date property keys from scheduledDate/validUntil to dateScheduledAt/dateValidUntil for consistency |
| src/message/messages.ts | Fixed typo (assoProp→assocProp); added date getters, assocNotificationTypes setter; enhanced isTargetingUser with date validation and new user types; added clearHiddenProps and replaceBodyTemplateVariables helper functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.