Retrieve split up JSON files#62
Conversation
…loading message/modal required
|
Most of the work is done. I've just encountered a nasty bug when clicking on the Background button in the sidebar. I'll take a look at this next week as I'm moving onto my other project today. I think the rest of the code is ready for review though. |
SutarPrasad
left a comment
There was a problem hiding this comment.
Looks Good. One small suggestion was added as a comment.
| </Button> | ||
|
|
||
| if (plotData.length === 0) { | ||
| return <div>Retrieving data...</div>; |
There was a problem hiding this comment.
An icon from here can be helpful:
https://mui.com/material-ui/material-icons/?query=loading
|
I think chunking data makes sense if you've exhausted the potential for data compression, alternate data file formats, and reducing needless precision. Have you determined that even with those three approaches the total size is still not under 1MB? If so, ship it! If not, I'd encourage you to investigate those to see if you could keep the code simple and still load all the data at once. |
This implements the dynamic retrieval of JSON files which hold each source (species, site, instrument, inlet...)
CHANGELOG.mdfile if fixing a bug or adding a new featureTODO
this.props.siteStructure is undefinedon clicking on onBackground