Fix missing tag trigger for PyPI release workflow#291
Merged
Conversation
Closed
Agent-Logs-Url: https://github.com/openghg/fluxie/sessions/6a30c5b1-232b-47b4-9655-7623a1d52745 Co-authored-by: lionel42 <43442120+lionel42@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing tags command in CI YAML for versioning
Fix missing tag trigger for PyPI release workflow
Mar 30, 2026
Collaborator
|
Are you sure this is going to work when I tag ? Maybe link to the official doc ? @copilot |
lionel42
approved these changes
Mar 30, 2026
lionel42
approved these changes
Mar 30, 2026
Member
|
Hi @lionel42 , I suggest to test this by using dry run flag again and pushing the tag, as you can always delete the pushed tag. |
Collaborator
|
@SutarPrasad Any chance you manage to check and merge this ? |
Member
|
Hi @lionel42 apologies for getting this delayed. I'll be looking at this tomorrow. I was on holiday. |
SutarPrasad
approved these changes
May 13, 2026
Member
|
Hi @lionel42 this is ready. You can verify the testing by opening publish tab on the below page where you will see the tag pushed is recognised to build the distribution files and dry run command was used to test the Trusted publisher. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
release_pypijob'sif:condition checksstartsWith(github.ref, 'refs/tags/'), but the workflow'son.pushonly listed branches — so pushing a tag never triggered the workflow in tag context.github.refremainedrefs/heads/devel, making the condition permanentlyfalse.Change
Added
tags: ["v*"]to thepushtrigger:This ensures pushing a tag like
v2.1.0triggers the workflow withgithub.ref = refs/tags/v2.1.0, allowing thebuild→release_pypichain to execute correctly.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.