NPL: Adding height info of '17m' (from local attributes.json file)#2
Open
rt17603 wants to merge 1 commit into
Open
NPL: Adding height info of '17m' (from local attributes.json file)#2rt17603 wants to merge 1 commit into
rt17603 wants to merge 1 commit into
Conversation
…ther than 'NA' currently included.
Contributor
|
This looks fine to me. There is a new field in here called 'status' and it is set to current. Is this something that should be rolled out broadly? Also is this current as it is under the LGHG project. |
Contributor
Author
Good question - it may be that we don't need this in our site_info.json anymore - who would know do you think if it would be worth including this? |
Contributor
|
@mrghg Do we need an entry called 'status' in the json. It is another thing to have to keep updating... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current "height" for NPL (LGHG inlet at National Physical Laboratory) is listed as "NA" within the
site_info.jsonfile.When processing in OpenGHG at the moment this is using a value from the locally stored
attributes.jsonfile instead which lists the inlet as "17m" rather than "NA". (This information may have originally been supplied by Daniel Hoare).Adding the "17m" to the
site_info.jsonto ensure all inlet information is retrieved from one place.