Skip to content

[TEMP]Inner domain adaptation#359

Open
SutarPrasad wants to merge 69 commits into
develfrom
inner_domain_adaptation
Open

[TEMP]Inner domain adaptation#359
SutarPrasad wants to merge 69 commits into
develfrom
inner_domain_adaptation

Conversation

@SutarPrasad
Copy link
Copy Markdown
Member

@SutarPrasad SutarPrasad commented Mar 2, 2026

  • Summary of changes

  • Please check if the PR fulfills these requirements

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passing
  • Documentation and tutorials updated/added
  • Added an entry to the CHANGELOG.md file
  • Added any new requirements to requirements.txt

@SutarPrasad
inner_domain
07a2dfc
@SutarPrasad
not_merge
3b08f8b
@SutarPrasad
paris hardcoded for test
e744f2e
@SutarPrasad
pulling fp and innner domain fp separately and passing to merged_scen…
874b8a1 
…ario_data
@SutarPrasad
flux is kept to fetch europe domain, calls to get_footprint_data are …
4e92b33 
…done separately so inner domain fp are fetched correctly
@SutarPrasad
6km fp_x_flux is added as a separate variable
1cd0a8d
@SutarPrasad
inner_fp_store and inner_domain is added to fixedbasisMCMC
2e7d17e
@SutarPrasad
combine_inner_outer_fp_x_flux
b7bd81d
@SutarPrasad
fp_x_flux fetched
6d55254
@SutarPrasad
adding extra print statements
96c6d7c
@SutarPrasad
commenting inner-domain as we are regridding to europe domain before …
c733114 
…this soon to be changed
@SutarPrasad
removed hardcoded 6km
ab727b4
@SutarPrasad
inner domain flux
27622d2
@SutarPrasad
getting inner flux for inner scenario
db9af9b
@SutarPrasad
calculating H_inner
bfa1735
@SutarPrasad
removed inner flux
e8a9af7
@SutarPrasad
inner flux removal
0541897
@SutarPrasad
flux to inner
e7a872b
brendan-m-murphy
brendan-m-murphy reviewed Mar 17, 2026
View reviewed changes
Comment thread openghg_inversions/inversion_data/scenario.py Outdated
scenario_combined = scenario_combined.copy()

# 6km fp_x_flux is added as a separate variable to the combined dataset, and can be merged with the EUROPE fp_x_flux.
scenario_combined["fp_x_flux_inner"] = inner_domain_merged["fp_x_flux"]
Copy link
Copy Markdown
Contributor

@brendan-m-murphy brendan-m-murphy Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still going to force alignment of lat and lon. The inner fp_x_flux needs to be separate from the normal fp_x_flux until after basis functions are applied.

@SutarPrasad SutarPrasad linked an issue Apr 13, 2026 that may be closed by this pull request
Adapt Inversions to handle inner domain #388
Open
Copilot AI mentioned this pull request Apr 17, 2026
Draft
SutarPrasad and others added 15 commits April 23, 2026 08:02
@SutarPrasad
handling of separate nodes in the code
4584cfe
@SutarPrasad
considers hx solved separately and 0 at inner domain
85cab69
@SutarPrasad
inner domain passing to basis function wrapper
189082c
@SutarPrasad
passing inner domain
53408e0
@SutarPrasad
aaplying mask on standard footprint if inner_domain is not none
2bec153
@SutarPrasad
removed masking from fp_sensitivity as fp is masked in get_data
ee6856a
@SutarPrasad
applying mask on standard_fp f inner domain is present
86334d9
@SutarPrasad
calculating inner basis data array for inner fp and flux by checking …
29a4726 
…if inner domain is not None

Co-authored-by: Copilot <copilot@github.com>
@SutarPrasad
inner flux dic accepted by merged scenario
a5dea90
@SutarPrasad
inner emissions store is passed to fetch flux for inner domain
359e9fb
@SutarPrasad
temp ini needs update for default paths to stores
fbe9be5
@SutarPrasad
passing inner emissions store
278ec94
@SutarPrasad
inner basis func is accepted in fp_sensitivity and applies fp basis f…
309d7ba 
…unction accordingly
@SutarPrasad
flux and fp based on standard and inner scenario are fetched
bf81d5b
@SutarPrasad
requires update to paths in conftest too
55df001
@SutarPrasad SutarPrasad requested review from brendan-m-murphy and removed request for brendan-m-murphy May 12, 2026 12:44
@SutarPrasad SutarPrasad self-assigned this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendan-m-murphy brendan-m-murphy brendan-m-murphy left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@SutarPrasad SutarPrasad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adapt Inversions to handle inner domain

3 participants

@SutarPrasad @brendan-m-murphy